Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to stratum-deps v1.3.4 #322

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Update to stratum-deps v1.3.4 #322

merged 1 commit into from
Jan 1, 2025

Conversation

ffoulkes
Copy link
Collaborator

@ffoulkes ffoulkes commented Jan 1, 2025

  • Link with re2::re2 instead of gRPC::re2.

@ffoulkes
Modify to use discrete re2 package
018c617 
Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes ffoulkes mentioned this pull request Jan 1, 2025
Merged
@ffoulkes ffoulkes changed the title Modify to use discrete re2 package Update to stratum-deps v1.3.4 Jan 1, 2025
5abeel
5abeel approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit 3975e21 into split-arch Jan 1, 2025
5 checks passed
@ffoulkes ffoulkes deleted the re2-fix branch January 1, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffoulkes @5abeel