Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: Modernize ruff, enable safe fixes and formatting, drop black and sort #102

Closed
wants to merge 2 commits into from

Conversation

boxydog
Copy link

@boxydog boxydog commented Jan 1, 2025

Also:

  • add TODO for more ruff linters.
  • Add pre-commit github action to check formatting, linting, etc.

closes #104

@boxydog boxydog mentioned this pull request Jan 1, 2025
@isaacharrisholt
Copy link
Owner

I think this is somewhat superseded by #105, but once that's in, feel free to suggest any more rules you think are required.

@boxydog
Copy link
Author

boxydog commented Jan 7, 2025

I think this is somewhat superseded by #105, but once that's in, feel free to suggest any more rules you think are required.

Sounds good.

I think the only thing in this PR not in #105 is the github action for a pre-commit check in tests.yml.

Some of the other stuff (pyproject.toml config) looks to have been copied over, which seems good to me.

DavidGeorge528 added a commit to DavidGeorge528/quiffen that referenced this pull request Jan 8, 2025
@boxydog
Copy link
Author

boxydog commented Jan 8, 2025

Looks like this is superceded by #105

@boxydog boxydog closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More ruff checks?
2 participants