Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowScalingCoefficents option to Chemistry checker #646

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

sjd210
Copy link
Contributor

@sjd210 sjd210 commented Oct 4, 2024

Moves option for coefficient scaling from content editor to the chemistry checker:


Main PR here.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 34.17%. Comparing base (95d7ef1) to head (d5161b3).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
...tg/isaac/quiz/IsaacSymbolicChemistryValidator.java 0.00% 7 Missing ⚠️
.../dtg/isaac/dos/IsaacSymbolicChemistryQuestion.java 33.33% 2 Missing ⚠️
...g/isaac/dto/IsaacSymbolicChemistryQuestionDTO.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   34.15%   34.17%   +0.01%     
==========================================
  Files         520      520              
  Lines       23241    23254      +13     
  Branches     2848     2850       +2     
==========================================
+ Hits         7939     7946       +7     
- Misses      14501    14507       +6     
  Partials      801      801              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjd210
Copy link
Contributor Author

sjd210 commented Oct 23, 2024

This PR now also allows for certain approved error messages from the Chemistry Checker to be displayed front-end while still being otherwise handled as errors. In this case, we have "Division by zero is undefined!"

@jacbn jacbn merged commit 04a0452 into master Oct 25, 2024
3 checks passed
@jacbn jacbn deleted the improvement/new-chemistry-options branch October 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants