Sort users in groups more consistently with Excel #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the _right_ fix, which would involve using collations correctly and working out what language we wanted to sort using. But assuming most people are using Excel in English, this fixes the most common case where sort does not match; apostrophes in names. Just removing the character does not lead to a consistent sort, however, so it may be worth reviewing that if people notice. This goes back to the in-place approach from the original PR, since comparator chaining like this is nicer. Neaten the tests, add more test cases for the apostrophe cases.
This still won't help with names identical except in an apostrophe in the first name, but that is both much less likely and would make the sorting still more expensive to compute (because the comparators are nested in reverse order).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 34.15% 34.16%
=======================================
Files 520 520
Lines 23244 23246 +2
Branches 2849 2849
=======================================
+ Hits 7939 7941 +2
Misses 14504 14504
Partials 801 801 ☔ View full report in Codecov by Sentry. |
axlewin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the right fix, which would involve using collations correctly and working out what language we wanted to sort using. But assuming most people are using Excel in English, this fixes the most common case where sort does not match; apostrophes in names. Just removing the character does not lead to a consistent sort, however, so it may be worth reviewing that if people notice.
This goes back to the in-place approach from the original PR, since comparator chaining like this is nicer.
Neaten the tests, add more test cases for the apostrophe cases.