Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort users in groups more consistently with Excel #648

Merged
merged 2 commits into from
Oct 21, 2024

Commits on Oct 9, 2024

  1. Sort users in groups more consistently with Excel

    This isn't the _right_ fix, which would involve using collations
    correctly and working out what language we wanted to sort using. But
    assuming most people are using Excel in English, this fixes the most
    common case where sort does not match; apostrophes in names.
    Just removing the character does not lead to a consistent sort, however,
    so it may be worth reviewing that if people notice.
    
    This goes back to the in-place approach from the original PR, since
    comparator chaining like this is nicer.
    
    Neaten the tests, add more test cases for the apostrophe cases.
    jsharkey13 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    454361a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Force a definite sort order to fix randomised test

    This still won't help with names identical except in an apostrophe in
    the first name, but that is both much less likely and would make the
    sorting still more expensive to compute (because the comparators are
    nested in reverse order).
    jsharkey13 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ed7e0af View commit details
    Browse the repository at this point in the history