Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve question finder default context race conditions #1131

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Resolve question finder default context race conditions #1131

wants to merge 11 commits into from
+19 −18

Commits on Sep 17, 2024

  1. Prevent getting stuck on default context

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b2758e1 View commit details
    Browse the repository at this point in the history

  2. Prevent another case of being stuck on default

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ccc3bfa View commit details
    Browse the repository at this point in the history

  3. Remove extra URL update

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    94675ae View commit details
    Browse the repository at this point in the history

  4. Add userContextDefault to useEffect parameters

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    50e0119 View commit details
    Browse the repository at this point in the history

  5. Cleanup extra linebreak

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e13c70c View commit details
    Browse the repository at this point in the history

  6. Restore missing linebreak

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    179ad22 View commit details
    Browse the repository at this point in the history

  7. Fix linting

    @sjd210
    sjd210 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    78c00e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Set searchAndUpdateURL to run correctly

    @sjd210
    sjd210 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7ffd4fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into hotfix/question-finder-page-loading

    @sjd210
    sjd210 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    75a1bc0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bug/question-finder-loading' into hotfix/question-finde… 

    …r-page-loading
    @sjd210
    sjd210 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fc5fc66 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Update q finder filter from account settings 

    The previous code set the stage and exam board settings from the user's viewing context. Although the naming is a little complicated, the user's viewing context is not the same as the user's account level registered contexts. It is those account level registered contexts that we are interested in for pre-populating filters.
If the user comes to the question finder with query params specifying the stages and exambaords filter settings they take presedence over account settings.
    @mlt47
    mlt47 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    82be94c View commit details
    Browse the repository at this point in the history