-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve question finder default context race conditions #1131
Open
sjd210
wants to merge
11
commits into
master
Choose a base branch
from
hotfix/question-finder-page-loading
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−18
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2758e1 - Browse repository at this point
Copy the full SHA b2758e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccc3bfa - Browse repository at this point
Copy the full SHA ccc3bfaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94675ae - Browse repository at this point
Copy the full SHA 94675aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50e0119 - Browse repository at this point
Copy the full SHA 50e0119View commit details -
Configuration menu - View commit details
-
Copy full SHA for e13c70c - Browse repository at this point
Copy the full SHA e13c70cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 179ad22 - Browse repository at this point
Copy the full SHA 179ad22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78c00e1 - Browse repository at this point
Copy the full SHA 78c00e1View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7ffd4fa - Browse repository at this point
Copy the full SHA 7ffd4faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75a1bc0 - Browse repository at this point
Copy the full SHA 75a1bc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc5fc66 - Browse repository at this point
Copy the full SHA fc5fc66View commit details
Commits on Oct 8, 2024
-
Update q finder filter from account settings
The previous code set the stage and exam board settings from the user's viewing context. Although the naming is a little complicated, the user's viewing context is not the same as the user's account level registered contexts. It is those account level registered contexts that we are interested in for pre-populating filters. If the user comes to the question finder with query params specifying the stages and exambaords filter settings they take presedence over account settings.
Configuration menu - View commit details
-
Copy full SHA for 82be94c - Browse repository at this point
Copy the full SHA 82be94cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.