-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve question finder default context race conditions #1131
Open
sjd210
wants to merge
11
commits into
master
Choose a base branch
from
hotfix/question-finder-page-loading
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−18
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b2758e1
Prevent getting stuck on default context
sjd210 ccc3bfa
Prevent another case of being stuck on default
sjd210 94675ae
Remove extra URL update
sjd210 50e0119
Add userContextDefault to useEffect parameters
sjd210 e13c70c
Cleanup extra linebreak
sjd210 179ad22
Restore missing linebreak
sjd210 78c00e1
Fix linting
sjd210 7ffd4fa
Set searchAndUpdateURL to run correctly
sjd210 75a1bc0
Merge branch 'master' into hotfix/question-finder-page-loading
sjd210 fc5fc66
Merge branch 'bug/question-finder-loading' into hotfix/question-finde…
sjd210 82be94c
Update q finder filter from account settings
mlt47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only blocking change. Anything else like removing the meaningless "all" tag can be made into its own card, since I think we're deciding that having no filters applied when logged out is fine.
There are probably other ways to handle this line, but this seems clean to me.