#216 add modal window email varify #262
Conversation
| mode: 'all', | ||
| }); | ||
|
|
||
| const { setIsValid } = props; |
There was a problem hiding this comment.
You can destructure it directly in function params
export function ResendActivationFormContentComponent(({ setIsValid })) {
| data: dataToSend | ||
| }).then(res => console.log(res.data)).catch(error => console.log(error)); | ||
| console.log(process.env.REACT_APP_BASE_API_URL); | ||
| navigate('/login'); |
There was a problem hiding this comment.
I think we should navigate users only when activation is successful and show error when smth went wrong
There was a problem hiding this comment.
Fixed.
What about error, It will probably be better to do this in a new task because I need to come up with a design for the error?
There was a problem hiding this comment.
I do not think that we have a design for every second error state. I would recommend using existing toast alerts
| }).then(res => console.log(res.data)).catch(error => console.log(error)); | ||
| console.log(process.env.REACT_APP_BASE_API_URL); |
There was a problem hiding this comment.
Do we need all these logs in the production code?
| @@ -0,0 +1,112 @@ | |||
| .modal { | |||
| position: absolute; /* or fixed */ | |||
There was a problem hiding this comment.
What does this comment mean?
https://stackoverflow.blog/2021/12/23/best-practices-for-writing-code-comments/
| color: var(--character-title-85, rgba(0, 0, 0, 0.85)); | ||
| font-feature-settings: "calt" off; | ||
|
|
||
| /* Text/Body/16-Semi bold */ |
There was a problem hiding this comment.
Very obvious comment. Check best practices above
There was a problem hiding this comment.
Fixed. I copied styles for buttons, etc., and forgot to remove these comments.
| import axios from 'axios'; | ||
| import styles from './ResendActivationFormContent.module.css'; | ||
|
|
||
| export function ResendActivationFormContentComponent({ setIsValid }) { |
There was a problem hiding this comment.
Could you add prop types here
Page about confirming your email
Resend email activation
Successful confirmation via email link
Failed confirmation via email link
