731 saved comapnies updates UI #735
Conversation
| useEffect(() => { | ||
| setSavedIsUpdated(data.saved_is_updated); | ||
| }, [data.saved_is_updated]); |
| ></StarForLike> | ||
| <div className={css['bell-container']}> | ||
| <BellForUpdates | ||
| className={savedIsUpdated ? '' : 'hidden'} |
There was a problem hiding this comment.
Do we need it? We do not use className prop in the BellForUpdates
There was a problem hiding this comment.
Deleted redundant code
| <div className={css['bell-container']}> | ||
| <BellForUpdates | ||
| className={savedIsUpdated ? '' : 'hidden'} | ||
| savedIsUpdated={savedIsUpdated} |
There was a problem hiding this comment.
I'm wondering why we can't use data.saved_is_updated directly.
| @@ -107,7 +107,7 @@ | |||
| } | |||
|
|
|||
| .content__common-info { | |||
| width: 1169px; | |||
| width: 1150px; | |||
There was a problem hiding this comment.
Have you tested it with screens different than 1150?
There was a problem hiding this comment.
Everything seems to work ok with this task on various resolutions, but this whole issue with hardcoded sizes in pixels will be fixed in future
|
|
||
| const { Paragraph } = Typography; | ||
|
|
||
| export default function ProfileCard({ isAuthorized, data }) { | ||
| const { user } = useAuth(); | ||
| const [isSaved, setIsSaved] = useState(data.is_saved); | ||
| const [savedIsUpdated, setSavedIsUpdated] = useState(data.saved_is_updated); |
There was a problem hiding this comment.
I'm wondering whether we can pass a callback to update it instead of cleaning it in the state.
There was a problem hiding this comment.
Please check the new implementation, whether it is correct, or not
created visuall representation for saved companies updates, whenever saved company is updated, user will see a bell on its profile card
#731