-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
731 saved comapnies updates UI #735
Changes from 9 commits
add747f
ad9e02d
a85adbe
7ed970f
8c72e89
0eeb851
067b43c
0d5858b
040f6f0
a7a09ff
08d377b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import PropTypes from 'prop-types'; | ||
import styles from './BellForUpdates.module.css'; | ||
|
||
export default function BellForUpdates({ savedIsUpdated }){ | ||
return ( | ||
<img | ||
src={`${process.env.PUBLIC_URL}/svg/bell-icon.svg`} | ||
className={`${styles['bell']} ${!savedIsUpdated ? styles['hidden'] : ''}`} | ||
alt="Bell Icon" | ||
/> | ||
|
||
); | ||
} | ||
|
||
BellForUpdates.propTypes={ | ||
savedIsUpdated: PropTypes.bool.isRequired, | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
.bell { | ||
color: #ffd800; | ||
font-size: 24px; | ||
margin-right: 5px; | ||
} | ||
|
||
.bell.hidden { | ||
visibility: hidden; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -107,7 +107,7 @@ | |
} | ||
|
||
.content__common-info { | ||
width: 1169px; | ||
width: 1150px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you tested it with screens different than 1150? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything seems to work ok with this task on various resolutions, but this whole issue with hardcoded sizes in pixels will be fixed in future |
||
color: var(--main-grey-90, #25292c); | ||
font-feature-settings: "calt" off; | ||
|
||
|
@@ -126,4 +126,12 @@ | |
align-self: stretch; | ||
max-width: 100%; | ||
gap: 8px; | ||
} | ||
|
||
.bell-container { | ||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
width: 30px; | ||
height: 100%; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether we can pass a callback to update it instead of cleaning it in the state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the new implementation, whether it is correct, or not