Table: fix the empty table column cell element #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit 9ef1e18 Author: Mat Harris <mat.harris@ithaka.org> Date: Fri Dec 8 12:06:10 2023 -0500 A11y revamp: Pharos buttons (non-breaking change) (ithaka#628) * docs: add @sirrah-tam as a contributor * feat(button): add a11y naming convention for aria * feat(button): add aria-description support * chore: add changset * Update packages/pharos/src/components/button/pharos-button.ts Co-authored-by: Dane Hillard <github@danehillard.com> * Update packages/pharos/src/components/button/pharos-button.ts Co-authored-by: Dane Hillard <github@danehillard.com> * feat(button): move property deprecated flag * fix(button): remove ts-ignore after lit upgrade * feat(button): add a11y state typing * fix: add TODO for future reference Co-authored-by: Dane Hillard <github@danehillard.com> * fix(a11y attributes): update AriaHiddenState name --------- Co-authored-by: Dane Hillard <github@danehillard.com>
sirrah-tam
requested review from
jialin-he,
mtorres3 and
satya-achanta-venkata
and removed request for
a team
🦋 Changeset detectedLatest commit: 882671a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Going to close this PR and re-open with a clean commit history |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Resolves #724
How does this change work?
Updates the
<tb></tb>to<td></td>