Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: fix the empty table column cell element #725

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bb1cbfd
chore: merge upstream
sirrah-tam Dec 8, 2023
44aacf1
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Dec 18, 2023
39cb08f
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 4, 2024
dff0e98
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 17, 2024
be8cf8e
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 18, 2024
d78784b
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 19, 2024
8b551ac
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 22, 2024
1c63985
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 22, 2024
e5422d1
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Jan 31, 2024
3dc0dfe
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Feb 14, 2024
05519cb
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Feb 28, 2024
30648c2
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 4, 2024
2d89f5b
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 8, 2024
60610de
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 8, 2024
cab7b13
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 11, 2024
873daac
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 11, 2024
cd91df4
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 12, 2024
0acdea4
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 14, 2024
d8c9545
Merge branch 'develop' of github.com:ithaka/pharos into develop
sirrah-tam Mar 15, 2024
d869370
fix(table): update empty table column header
sirrah-tam Mar 15, 2024
b01614a
chore: add changeset
sirrah-tam Mar 15, 2024
882671a
fix(table): change from th to td
sirrah-tam Mar 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-rabbits-double.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ithaka/pharos": patch
---

Fix empty table column header cell
2 changes: 1 addition & 1 deletion packages/pharos/src/components/table/pharos-table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export class PharosTable extends ScopedRegistryMixin(PharosElement) {
if (column.name) {
return html`<th scope="col">${column.name}</th>`;
} else {
return html`<tb></tb>`;
return html`<td></td>`;
}
});
}
Expand Down
Loading