Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22 #827

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

michael-iden
Copy link
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
#826

How does this change work?
Remove overflow property for an element that will never overflow

Additional context

@michael-iden michael-iden requested a review from a team as a code owner October 28, 2024 15:15
@michael-iden michael-iden requested review from sirrah-tam, jialin-he and mtorres3 and removed request for a team October 28, 2024 15:15
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 1f3751b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michael-iden michael-iden linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 66.32 KB (-0.03% 🔽)

.tool-versions Outdated Show resolved Hide resolved
@michael-iden michael-iden changed the title fix(modal): remove overflow property that causes unnecessary scrollbars fix(modal & tabs): remove overflow property that causes unnecessary scrollbars Nov 13, 2024
@michael-iden michael-iden requested a review from daneah November 18, 2024 15:48
@michael-iden michael-iden changed the title fix(modal & tabs): remove overflow property that causes unnecessary scrollbars fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22 Nov 21, 2024
@brentswisher
Copy link
Contributor

I see the size report action is failing, wondering if that is because of the node 22 update?

@michael-iden
Copy link
Contributor Author

@brentswisher I also noticed the size job failing and it does relate to node 22 but I don't know how to fix it. It might be a task that relies the latest build.

My interpretation of the error is that the job runs a build against both the current branch and develop with node22, and its failing to run against develop because it has the unsupported node 20 syntax. So it should get corrected once we merge and develop gets these updates to evaluate in the next PR

@michael-iden michael-iden merged commit 91870ce into develop Nov 22, 2024
6 of 7 checks passed
@michael-iden michael-iden deleted the bugfix/modal-overflow branch November 22, 2024 13:59
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal: Y Scrollbar region always present when using a mouse
3 participants