-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22 #827
Conversation
🦋 Changeset detectedLatest commit: 1f3751b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
I see the size report action is failing, wondering if that is because of the node 22 update? |
@brentswisher I also noticed the size job failing and it does relate to node 22 but I don't know how to fix it. It might be a task that relies the latest build. My interpretation of the error is that the job runs a build against both the current branch and develop with node22, and its failing to run against develop because it has the unsupported node 20 syntax. So it should get corrected once we merge and develop gets these updates to evaluate in the next PR |
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
#826
How does this change work?
Remove overflow property for an element that will never overflow
Additional context