Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22 #827

Merged
merged 8 commits into from
Nov 22, 2024
Merged

fix(modal & tabs): remove overflow property that causes unnecessary scrollbars and update to Node 22 #827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e4157e3
fix(modal): remove overflow property that causes unnecessary scrollbars
michael-iden Oct 28, 2024
bdf77ee
fix(modal): update supported node version, yarn and docs
michael-iden Oct 28, 2024
fd8d91e
fix(modal): fix node 22 import assertion syntax
michael-iden Oct 28, 2024
ed1573a
fix(modal): update changelog
michael-iden Oct 28, 2024
054be6e
fix(tabs): change overflow on tabs from scroll to auto
michael-iden Nov 13, 2024
da341aa
Merge branch 'develop' into bugfix/modal-overflow
michael-iden Nov 18, 2024
e09c07d
Merge branch 'develop' into bugfix/modal-overflow
michael-iden Nov 21, 2024
1f3751b
fix(tabs): update readme for node 22
michael-iden Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-snakes-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ithaka/pharos': patch
---

Remove unnecessary scrollbars from modal
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 20.11.1
nodejs 20.18.0
1 change: 0 additions & 1 deletion packages/pharos/src/components/modal/pharos-modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
flex-direction: column;
height: 100%;
pointer-events: auto;
overflow-y: scroll;
background-color: var(--pharos-modal-color-background-content);
background-clip: padding-box;
border-radius: var(--pharos-radius-base-standard);
Expand Down
Loading