Automatically determines the cgroup values to allow at the LXC level#3
Open
lcotonea wants to merge 2 commits intojammsen:mainfrom
Open
Automatically determines the cgroup values to allow at the LXC level#3lcotonea wants to merge 2 commits intojammsen:mainfrom
lcotonea wants to merge 2 commits intojammsen:mainfrom
Conversation
jammsen
requested changes
Jan 6, 2026
| read -r -p "Enter gateway [$GW_TEMPLATE]: " GATEWAY | ||
| GATEWAY=${GATEWAY:-$GW_TEMPLATE} | ||
|
|
||
| ROOT_FS_LOCATION_TEMPLATE="local-zfs" |
Owner
There was a problem hiding this comment.
Didnt you create for this code-change a different PR already?
Author
There was a problem hiding this comment.
Right. Mishandling. (again :) )
Owner
|
I can test this on the weekend. |
|
fyi i did test this myself and can confirm it worked. the only thing i needed to adapt was to change card0 to card1. also i am not using zfs thus i needed to change the filesystem to ROOT_FS_LOCATION_TEMPLATE="local-lvm" you can see this in my fork over at https://github.com/eikaramba/proxmox-setup-scripts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my case, the cgroups values are differents. So this pull request is a purpose to automatically compute the right cgroup values