Skip to content

Automatically determines the cgroup values to allow at the LXC level #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lcotonea wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Automatically determines the cgroup values to allow at the LXC level #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5995551
Allow to choice the root FS location
Dec 31, 2025
880ff0b
Automatically determines the cgroup values to allow at the LXC level
Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions host/031 - create-gpu-lxc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ GW_TEMPLATE="10.0.0.1"
read -r -p "Enter gateway [$GW_TEMPLATE]: " GATEWAY
GATEWAY=${GATEWAY:-$GW_TEMPLATE}

ROOT_FS_LOCATION_TEMPLATE="local-zfs"
Copy link
Owner

@jammsen jammsen Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt you create for this code-change a different PR already?

Copy link
Author

@lcotonea lcotonea Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Mishandling. (again :) )

read -r -p "Enter root fs location [$ROOT_FS_LOCATION_TEMPLATE]: " ROOT_FS_LOCATION
ROOT_FS_LOCATION=${ROOT_FS_LOCATION:-$ROOT_FS_LOCATION_TEMPLATE}

# Generate random MAC address
MAC_ADDRESS=$(printf 'BC:24:11:%02X:%02X:%02X\n' $((RANDOM%256)) $((RANDOM%256)) $((RANDOM%256)))

Expand Down Expand Up @@ -213,7 +217,7 @@ pct create "$CONTAINER_ID" local:vztmpl/ubuntu-24.04-standard_24.04-2_amd64.tar.
--net0 "name=eth0,bridge=vmbr0,firewall=1,gw=$GATEWAY,hwaddr=$MAC_ADDRESS,ip=$IP_ADDRESS/24,type=veth" \
--ostype ubuntu \
--password testing \
--rootfs local-zfs:160 \
--rootfs $ROOT_FS_LOCATION:160 \
--swap 4096 \
--tags "docker;ollama;${ADDITIONAL_TAGS}" \
--unprivileged 0
Expand All @@ -224,14 +228,30 @@ echo -e "${GREEN}>>> Added LXC container with ID $CONTAINER_ID${NC}"
if [ "$GPU_TYPE" == "1" ]; then
# AMD GPU Configuration
echo -e "${GREEN}>>> Configuring AMD GPU passthrough${NC}"

# search cgroup of /dev/kfd
KFD_CGROUP_MAJOR_MINOR=$(ls -al /dev/kfd | sed 's/,//' | awk '{print $5, $6}')
KFD_CGROUP_MAJOR=$(echo "$KFD_CGROUP_MAJOR_MINOR" | cut -d' ' -f1)
KFD_CGROUP_MINOR=$(echo "$KFD_CGROUP_MAJOR_MINOR" | cut -d' ' -f2)

# search cgroup of /dev/dri/card0
DRICARD0_CGROUP_MAJOR_MINOR=$(ls -al /dev/dri/card0 | sed 's/,//' | awk '{print $5, $6}')
DRICARD0_CGROUP_MAJOR=$(echo "$DRICARD0_CGROUP_MAJOR_MINOR" | cut -d' ' -f1)
DRICARD0_CGROUP_MINOR=$(echo "$DRICARD0_CGROUP_MAJOR_MINOR" | cut -d' ' -f2)

# search cgroup of /dev/dri/renderD128
DRENDERD128_CGROUP_MAJOR_MINOR=$(ls -al /dev/dri/renderD128 | sed 's/,//' | awk '{print $5, $6}')
DRENDERD128_CGROUP_MAJOR=$(echo "$DRENDERD128_CGROUP_MAJOR_MINOR" | cut -d' ' -f1)
DRENDERD128_CGROUP_MINOR=$(echo "$DRENDERD128_CGROUP_MAJOR_MINOR" | cut -d' ' -f2)

cat >> "/etc/pve/lxc/${CONTAINER_ID}.conf" << EOF
# ===== AMD GPU Passthrough Configuration =====
# PCI Address: $PCI_ADDRESS
# Using persistent by-path device names to ensure consistent mapping
# Allow access to cgroup devices (DRI and KFD)
lxc.cgroup2.devices.allow: c 226:* rwm
lxc.cgroup2.devices.allow: c 235:* rwm
lxc.cgroup2.devices.allow: c ${DRICARD0_CGROUP_MAJOR}:${DRICARD0_CGROUP_MINOR} rwm
lxc.cgroup2.devices.allow: c ${DRENDERD128_CGROUP_MAJOR}:${DRENDERD128_CGROUP_MINOR} rwm
lxc.cgroup2.devices.allow: c ${KFD_CGROUP_MAJOR}:${KFD_CGROUP_MINOR} rwm
# Mount DRI devices using persistent PCI paths
lxc.mount.entry: /dev/dri/by-path/pci-${PCI_ADDRESS}-card dev/dri/card0 none bind,optional,create=file
lxc.mount.entry: /dev/dri/by-path/pci-${PCI_ADDRESS}-render dev/dri/renderD128 none bind,optional,create=file
Expand Down