Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): use a fixed digit of SHORT_SHA for image name #1873

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

josephca
Copy link
Member

@josephca josephca commented Nov 1, 2024

Description

To have consistent image names with SHORT_SHA as a suffix, use git rev-parse --short=8. Otherwise, we would get inconsistent number of digits from the command.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link

sonarcloud bot commented Nov 1, 2024

Copy link
Contributor

github-actions bot commented Nov 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1873!

@josephca josephca changed the title use a fixed number of SHORT_SHA for image name chore(e2e): use a fixed digit of SHORT_SHA for image name Nov 1, 2024
Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira, PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f52f89f into janus-idp:main Nov 1, 2024
11 of 13 checks passed
@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/cherry-pick release-1.3

@openshift-cherrypick-robot

@kim-tsao: new pull request created: #1888

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@kim-tsao: new pull request created: #1889

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants