Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] chore(e2e): use a fixed digit of SHORT_SHA for image name #1888

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1873

/assign kim-tsao

Copy link

openshift-ci bot commented Nov 5, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a janus-idp member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

sonarcloud bot commented Nov 5, 2024

@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2024
Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@kim-tsao
Copy link
Member

kim-tsao commented Nov 5, 2024

/ok-to-test

@kim-tsao kim-tsao merged commit 401ac8e into janus-idp:release-1.3 Nov 5, 2024
5 of 7 checks passed
Copy link
Contributor

github-actions bot commented Nov 5, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1888!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants