feat(token): cache Fetch tokens by default #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opts to cache tokens returned by `Fetch` by default. Adds a new `Options` type that can be passed to `Fetch` to configure (disable) this behaviour. As part of this, the `allowUnauthenticated` function option has been moved to that struct. While the original bool is kept to prevent breaking changes, it will be removed before v1 so callers should update their calls ASAP.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 54.98% 55.81% +0.83%
==========================================
Files 17 18 +1
Lines 682 722 +40
==========================================
+ Hits 375 403 +28
- Misses 252 262 +10
- Partials 55 57 +2 ☔ View full report in Codecov by Sentry. |
|
DDR says "looks fine" 🥹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opts to cache tokens returned by
Fetchby default. Adds a newOptionstype that can be passed toFetchto configure (disable) thisbehaviour. As part of this, the
allowUnauthenticatedfunction optionhas been moved to that struct. While the original bool is kept to
prevent breaking changes, it will be removed before v1 so callers should
update their calls ASAP.