jax.numpy: implement scalar boolean indexing #19722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
jakevdp
force-pushed
the
scalar-bool-indexing
branch
3 times, most recently
from
41bc918
to
0f68834
Compare
jakevdp
commented
Feb 8, 2024
| raise IndexError( | ||
| f"Too many indices for array: array has ndim of {self.ndim}, but " | ||
| f"was indexed with {num_idx} non-None/Ellipsis indices.") | ||
|
|
There was a problem hiding this comment.
Removed this because the logic is wrong (boolean indices idx consume a number of dimensions equal to idx.ndim) and this condition is correctly checked in _index_to_gather.
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
force-pushed
the
scalar-bool-indexing
branch
from
0f68834
to
bbfd4f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18353