Test on Python 3.12 and Django 5.0 #248
Conversation
| python-version: | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| - '3.12' |
There was a problem hiding this comment.
Splitting one per line reduces future diff noise when adding/removing versions
| @@ -22,7 +22,7 @@ docs: | |||
| test: | |||
| @flake8 | |||
| @isort --check-only --diff formtools tests | |||
| @ coverage run `which django-admin` test tests | |||
| @ python -W error::DeprecationWarning -W error::PendingDeprecationWarning -m coverage run `which django-admin` test tests | |||
There was a problem hiding this comment.
I use this pattern on all my projects to expose all warnings - even those from coverage or Django.
| @@ -1,3 +1,3 @@ | |||
| coverage==4.5.4 | |||
| coverage==7.3.2 | |||
There was a problem hiding this comment.
Upgrade needed for 3.12 compatibility
| @@ -1,9 +1,10 @@ | |||
| [tox] | |||
| args_are_paths = false | |||
| envlist = | |||
| py{37,38,39,310,311}-django32 | |||
| py{38,39,310,311}-django32 | |||
There was a problem hiding this comment.
dropping 37 missed in 1d19b68
adamchainz
force-pushed
the
django_5.0
branch
from
5885fef
to
80bebe0
Compare
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 11 11
Lines 535 535
Branches 68 87 +19
=======================================
Hits 502 502
Misses 21 21
Partials 12 12 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Woops, looks like Python 3.11 is actually broken. I'll take a look into this tomorrow. |
|
Ah yes, I initially thought it was a CI issue, but then realized that Python 3.11 run is also launching 3.2 and 4.0 tests, and it shouldn't. |
Based on the changes made in #235.