Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Python 3.12 and Django 5.0 #248

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Test on Python 3.12 and Django 5.0 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ jobs:
fail-fast: false
max-parallel: 5
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
- '3.12'
Comment on lines +12 to +17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting one per line reduces future diff noise when adding/removing versions


steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ docs:
test:
@flake8
@isort --check-only --diff formtools tests
@ coverage run `which django-admin` test tests
@ python -W error::DeprecationWarning -W error::PendingDeprecationWarning -m coverage run `which django-admin` test tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this pattern on all my projects to expose all warnings - even those from coverage or Django.

@coverage report
@coverage xml

Expand Down
5 changes: 5 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ Changelog

This page details the changes in the various ``django-formtools`` releases.

Unreleased
----------

- Confirmed support for Python 3.12 and Django 5.0.

2.4.1 (2023-05-13)
------------------

Expand Down
2 changes: 2 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def read(*parts):
"Framework :: Django :: 4.0",
"Framework :: Django :: 4.1",
"Framework :: Django :: 4.2",
"Framework :: Django :: 5.0",
"Intended Audience :: Developers",
"License :: OSI Approved :: BSD License",
"Operating System :: OS Independent",
Expand All @@ -44,6 +45,7 @@ def read(*parts):
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Topic :: Internet :: WWW/HTTP",
],
zip_safe=False,
Expand Down
4 changes: 2 additions & 2 deletions tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
coverage==4.5.4
coverage==7.3.2
flake8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade needed for 3.12 compatibility

isort>=5.11.1, <6.0
isort>=5.11.1, <6.0
2 changes: 2 additions & 0 deletions tests/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,5 @@
STATIC_ROOT = 'static'

DEFAULT_AUTO_FIELD = 'django.db.models.AutoField'

USE_TZ = True
7 changes: 5 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
[tox]
args_are_paths = false
envlist =
py{37,38,39,310,311}-django32
py{38,39,310,311}-django32
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping 37 missed in 1d19b68

py{38,39,310,311}-django{40,41,42}
py{310,311}-djangomain
py{310,311,312}-django50
py{310,311,312}-djangomain

[testenv]
usedevelop = true
Expand All @@ -15,6 +16,7 @@ deps =
django40: Django>=4.0,<4.1
django41: Django>=4.1,<4.2
django42: Django>=4.2,<5.0
django50: Django>=5.0a1,<5.1
djangomain: https://github.com/django/django/archive/main.tar.gz
-r{toxinidir}/tests/requirements.txt
ignore_outcome =
Expand All @@ -28,3 +30,4 @@ python =
3.9: py39
3.10: py310
3.11: py311
3.12: py312
Loading