Skip to content

Comments

Refactor Kerberos and make state Runspace#88

Merged
jborean93 merged 2 commits intomainfrom
kerberos-refactor
Mar 11, 2025
Merged

Refactor Kerberos and make state Runspace#88
jborean93 merged 2 commits intomainfrom
kerberos-refactor

Conversation

@jborean93
Copy link
Owner

Refactors the Kerberos code to new standards used in some of my projects. Also includes the Kerberos error when failing to find the principal for better debugging purposes.

Sets the GlobalState to be Runspace specific rather than process wide. This will allow the module to be used in separate runspaces like with ForEach-Object -Parallel or other Runspace based APIs.

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 79.42387% with 50 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (165bd45) to head (34c1436).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/PSOpenAD.Module/OnImportAndRemove.cs 55.38% 26 Missing and 3 partials ⚠️
src/PSOpenAD/Native/Kerberos/UnparseName.cs 68.75% 3 Missing and 2 partials ⚠️
src/PSOpenAD/Native/Kerberos/CCDefault.cs 80.00% 3 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/InitContext.cs 78.57% 2 Missing and 1 partial ⚠️
src/PSOpenAD.Module/Completer.cs 0.00% 1 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/KerberosException.cs 80.00% 1 Missing and 1 partial ⚠️
src/PSOpenAD.Module/OpenADSessionFactory.cs 91.66% 0 Missing and 1 partial ⚠️
src/PSOpenAD/Native/GSSAPI.cs 0.00% 0 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/FreeDefaultRealm.cs 88.88% 0 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/FreeUnparsedName.cs 88.88% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #88       +/-   ##
===========================================
+ Coverage   68.74%   79.67%   +10.93%     
===========================================
  Files          53       62        +9     
  Lines        7174     7687      +513     
  Branches      896      899        +3     
===========================================
+ Hits         4932     6125     +1193     
+ Misses       1704     1341      -363     
+ Partials      538      221      -317     
Flag Coverage Δ
Linux_74_Heimdal 79.51% <76.54%> (+10.80%) ⬆️
Linux_74_MIT 79.41% <76.13%> (+10.74%) ⬆️
Linux_75_Heimdal 79.51% <76.54%> (+10.80%) ⬆️
Linux_75_MIT 79.41% <76.13%> (+10.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Refactors the Kerberos code to new standards used in some of my
projects. Also includes the Kerberos error when failing to find the
principal for better debugging purposes.

Sets the GlobalState to be Runspace specific rather than process wide.
This will allow the module to be used in separate runspaces like with
ForEach-Object -Parallel or other Runspace based APIs.
@jborean93 jborean93 merged commit fe171bb into main Mar 11, 2025
7 checks passed
@jborean93 jborean93 deleted the kerberos-refactor branch March 11, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant