Skip to content

Refactor Kerberos and make state Runspace #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jborean93 merged 2 commits into from
Mar 11, 2025

Ensure name is freed after reading

34c1436
Select commit
Loading
Failed to load commit list.
Merged

Refactor Kerberos and make state Runspace #88

Ensure name is freed after reading
34c1436
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 11, 2025 in 0s

79.67% (+10.93%) compared to 165bd45

View this Pull Request on Codecov

79.67% (+10.93%) compared to 165bd45

Details

Codecov Report

Attention: Patch coverage is 79.42387% with 50 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (165bd45) to head (34c1436).

Files with missing lines Patch % Lines
src/PSOpenAD.Module/OnImportAndRemove.cs 55.38% 26 Missing and 3 partials ⚠️
src/PSOpenAD/Native/Kerberos/UnparseName.cs 68.75% 3 Missing and 2 partials ⚠️
src/PSOpenAD/Native/Kerberos/CCDefault.cs 80.00% 3 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/InitContext.cs 78.57% 2 Missing and 1 partial ⚠️
src/PSOpenAD.Module/Completer.cs 0.00% 1 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/KerberosException.cs 80.00% 1 Missing and 1 partial ⚠️
src/PSOpenAD.Module/OpenADSessionFactory.cs 91.66% 0 Missing and 1 partial ⚠️
src/PSOpenAD/Native/GSSAPI.cs 0.00% 0 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/FreeDefaultRealm.cs 88.88% 0 Missing and 1 partial ⚠️
src/PSOpenAD/Native/Kerberos/FreeUnparsedName.cs 88.88% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #88       +/-   ##
===========================================
+ Coverage   68.74%   79.67%   +10.93%     
===========================================
  Files          53       62        +9     
  Lines        7174     7687      +513     
  Branches      896      899        +3     
===========================================
+ Hits         4932     6125     +1193     
+ Misses       1704     1341      -363     
+ Partials      538      221      -317

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov