Updated Plugin with DCT 15.0.0 SDK #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ankit-patil-hubs
commented
Apr 4, 2024
ankit-patil-hubs
commented
- Updated the plugin to use DCT 15.0.0 SDK
- Documentation update for 'Disable SSL certificate ' , updated the correct screenshot
ankit-patil-hubs
requested review from
elima-sugunan,
arunskurian,
nick-mathison and
Uddipaan-Hazarika
Uddipaan-Hazarika
approved these changes
Apr 4, 2024
nick-mathison
requested changes
Apr 4, 2024
| @@ -6,7 +6,7 @@ public class Constant { | |||
| public static final String UNIQUE_FILE_NAME = "delphix-VDB-"; | |||
| public static final String PROPERTIES = ".properties"; | |||
| public static final String FILE_NAME = "delphix-VDB"; | |||
| public static final String USER_AGENT = "Jenkins-3.1.1"; | |||
| public static final String USER_AGENT = "Jenkins-3.2.1"; | |||
There was a problem hiding this comment.
In the pom.xml the version says 3.2.0.
Anyway we can dynamically resolve the version so we don't have this issue?
There was a problem hiding this comment.
yes, those are. dynamically resolved
There was a problem hiding this comment.
I don't think the pom.xml issue is addressed.
There was a problem hiding this comment.
I didn't realize the jenkins bot updates this value.
nick-mathison
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.