Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Plugin with DCT 15.0.0 SDK #41

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Updated Plugin with DCT 15.0.0 SDK #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d2015
updated pom to use dct 15.0.0 and minor documentation updates
ankit-patil-hubs Apr 4, 2024
c5002a6
updated plugin version
ankit-patil-hubs Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ Install through Jenkins Plugin Manager or download [here](https://plugins.jenkin

After the plugin has been installed, DCT will need to be connected. Go to Manage Jenkins > Configure System, scroll down to the Delphix section, and enter your DCT URL. This URL will be automatically used for every plugin step on the Jenkins server.

Select the `SSL certificate check` checkbox if the DCT server has an insecure SSL Certificate.
Select the `Disable SSL certificate check` checkbox if the DCT server has an insecure SSL Certificate.
<br/>*We recommend configuring your DCT server with an SSL certificate for production usage.

![Alt text](images/configuration.png)
![Alt text](images/updated_configuration.png)

#### **Credentials**

Expand Down
Binary file removed images/configuration.png
View file
Open in desktop
Binary file not shown.
Binary file added images/updated_configuration.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
<dependency>
<groupId>commons-validator</groupId>
<artifactId>commons-validator</artifactId>
<version>1.7</version>
<version>1.8.0</version>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
Expand Down Expand Up @@ -97,12 +97,12 @@
<dependency>
<groupId>com.delphix</groupId>
<artifactId>dct-api</artifactId>
<version>8.0.1</version>
<version>15.0.0</version>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-common</artifactId>
<version>1.4.10</version>
<version>1.6.20</version>
</dependency>
<dependency>
<groupId>com.google.code.gson</groupId>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/jenkins/plugins/constant/Constant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ public class Constant {
public static final String UNIQUE_FILE_NAME = "delphix-VDB-";
public static final String PROPERTIES = ".properties";
public static final String FILE_NAME = "delphix-VDB";
public static final String USER_AGENT = "Jenkins-3.1.1";
public static final String USER_AGENT = "Jenkins-3.2.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the pom.xml the version says 3.2.0.

Anyway we can dynamically resolve the version so we don't have this issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, those are. dynamically resolved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the pom.xml issue is addressed.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize the jenkins bot updates this value.

public static final String CLIENT_NAME = "Jenkins";
public static final String CLIENT_NAME_HEADER = "x-dct-client-name";
public static final long WAIT_TIME = 20000;
Expand Down
Loading