Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle timeout from jibri as an error. #1144

Merged

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Mar 19, 2024

No description provided.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 28.98%. Comparing base (fb29dc8) to head (1e5181a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1144      +/-   ##
============================================
- Coverage     28.99%   28.98%   -0.02%     
  Complexity      478      478              
============================================
  Files           130      130              
  Lines          7912     7915       +3     
  Branches       1087     1087              
============================================
  Hits           2294     2294              
- Misses         5345     5348       +3     
  Partials        273      273              
Files Coverage Δ
...main/java/org/jitsi/jicofo/jibri/JibriSession.java 40.00% <0.00%> (-0.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb29dc8...1e5181a. Read the comment docs.

@bgrozev bgrozev merged commit ac6cb05 into jitsi:master Mar 19, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants