Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle timeout from jibri as an error. #1144

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions jicofo/src/main/java/org/jitsi/jicofo/jibri/JibriSession.java
Original file line number Diff line number Diff line change
Expand Up @@ -368,18 +368,24 @@ synchronized public void stop(Jid initiator)
logger.error(
"Unexpected response to stop iq: "
+ (stanza != null ? XmlStringBuilderUtil.toStringOpt(stanza) : "null"));
stopError(stopRequest.getTo());
}
}).onError(exception ->
{
logger.error("Error from stop request: " + exception.toString());
stopError(stopRequest.getTo());
});
}

JibriIq error = new JibriIq();
private void stopError(Jid jibriJid)
{
JibriIq error = new JibriIq();

error.setFrom(stopRequest.getTo());
error.setFailureReason(FailureReason.ERROR);
error.setStatus(Status.OFF);
error.setFrom(jibriJid);
error.setFailureReason(FailureReason.ERROR);
error.setStatus(Status.OFF);

processJibriIqFromJibri(error);
}
}).onError(exception ->
logger.error(
"Error sending stop iq: " + exception.toString()));
processJibriIqFromJibri(error);
}

private void cleanupSession()
Expand Down
Loading