Fix: Resolve mmap AttributeError on Windows #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an `AttributeError: module 'mmap' has no attribute 'PROT_READ'` that occurs when running the script on a Windows system. The `mmap.PROT_READ` attribute is not available in Python on Windows. This commit adds an OS check to use the Windows-compatible `mmap.ACCESS_READ` parameter instead, making the tool cross-platform.
Owner
|
This is pretty interesting as I really haven't run on windows for many years. I filed a separate issue to add windows to the basic CI I'm now running. #84 I think the I'm open to suggestions about formatters and linters. I just chose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an
AttributeError: module 'mmap' has no attribute 'PROT_READ'that occurs when running the script on a Windows system.The
mmap.PROT_READattribute is not available in Python on Windows. This commit adds an OS check to use the Windows-compatiblemmap.ACCESS_READparameter instead, making the tool cross-platform.