Skip to content

Fix: Resolve mmap AttributeError on Windows #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnoneil merged 2 commits into from
Oct 19, 2025
Merged

Fix: Resolve mmap AttributeError on Windows #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5941d
Fix: Resolve mmap AttributeError on Windows
zx3777 Oct 18, 2025
adb6934
Apply Black tool formatting
johnoneil Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion arib/mpeg/ts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,13 @@ def next_packet(filename, memorymap=True):
# memory map the file if necessary (prob requires 64 bit systems)
_file = f
if memorymap:
_file = mmap.mmap(f.fileno(), 0, prot=mmap.PROT_READ)
# --- START OF MODIFICATION ---
# This block checks the operating system to use the correct mmap parameter.
if os.name == "nt": # 'nt' is the name for Windows
_file = mmap.mmap(f.fileno(), 0, access=mmap.ACCESS_READ)
else: # For other systems like Linux or macOS
_file = mmap.mmap(f.fileno(), 0, prot=mmap.PROT_READ)
# --- END OF MODIFICATION ---

while True:
packet = _file.read(TS.PACKET_SIZE)
Expand Down