Update PATH when running generate_stubs on Windows #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisv
force-pushed
the
topic/stub_windows_path
branch
from
5067e0c
to
5c42e48
Compare
jorisv
force-pushed
the
topic/stub_windows_path
branch
from
5c42e48
to
d5ced68
Compare
nim65s
reviewed
Nov 22, 2023
Ok, no problem, you can remove yourself from the review (I didn't find if I can do it myself). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_stubsneed to load an uninstalled Python binding.This can be an issue when the Python binding have internal dependencies on Windows.
This PR modify the PATH to allow Python to find those internal dependencies.
On Linux and Mac, this is not an issue thanks to the RPATH.