fix: ignore fallback resource error in live smoke#54
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to ignore specific resource errors in the live smoke tests to reduce noise. The logic added to normalizeErrors correctly filters out the intended errors. However, the implementation can be simplified. I've provided a suggestion to make the filtering logic more concise.
| return errors.filter((entry) => { | ||
| if (/mcp\.revasserlabs\.com\/status/.test(entry)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (entry === "console:Failed to load resource: net::ERR_FAILED") { | ||
| return false; | ||
| } | ||
|
|
||
| return true; | ||
| }); |
There was a problem hiding this comment.
The filter logic can be made more concise by combining the conditions into a single boolean expression. This avoids the verbose if statements and is more idiomatic for a filter callback.
return errors.filter((entry) => !/mcp\.revasserlabs\.com\/status/.test(entry) && entry !== "console:Failed to load resource: net::ERR_FAILED");![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 374fd3fa73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (entry === "console:Failed to load resource: net::ERR_FAILED") { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
When allowHostedStatusFallback is true, this new condition drops every console:Failed to load resource: net::ERR_FAILED entry, not just the known mcp.revasserlabs.com/status fallback noise. In runLive, that means unrelated failed resource loads (for example CSS/image requests that only surface as this generic console error) can be silently ignored and the smoke test can pass despite a broken page, because the URL-specific filter is only applied to other error entry types. Please scope this suppression to the status request context instead of matching the bare console string globally.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing