Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team name validation in UI #174

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

stuebingerb
Copy link
Contributor

@stuebingerb stuebingerb commented Aug 17, 2023

Although it should be valid to have an unescaped -, at least Google Chrome and Firefox complain about an "Invalid character in character class" and completely skip validation, leading to confusion as to why team creation fails.

Also fixed the validation message to state the minimum number of characters and applied red text color on invalid input.

image

@stuebingerb
Copy link
Contributor Author

stuebingerb commented Aug 17, 2023

Also note that npm install complains about several vulnerabilities but since those include breaking changes and I am not feeling comfortable enough to verify everything is still working I decided to skip them. You might want to have a look yourself maybe.

@stuebingerb stuebingerb changed the title Fix team name validation Fix team name validation in UI Aug 17, 2023
Although it _should_ be valid to have an unescaped `-`, at least
Google Chrome and Firefox complain about an "Invalid character in
character class" and completely skip validation, leading to confusion
as to why team creation fails.

Also fixed the validation message to state the minimum number of
characters and applied red text color on invalid input.
@J12934
Copy link
Member

J12934 commented Aug 20, 2023

@stuebingerb you probably mean the vulns from the balancer backend package.json?
These are unfortunately not fixable right now as they can only be fixed once the kubernetes client node is done migrating away from the deprecated request node library: https://github.com/kubernetes-client/javascript/blob/master/FETCH_MIGRATION.md
Keeping an eye on that one but might still take a while. The vulnerabilities that request has so far probably also don't really apply for MultiJuicer but would still be very nice to get rid of them... 😔

Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh nice, thank you yeah i guess that was slightly wrong.

will probably tweak the coloring a bit :)

@J12934 J12934 merged commit 98f67d3 into juice-shop:main Aug 20, 2023
3 checks passed
J12934 added a commit that referenced this pull request Aug 20, 2023
@J12934 J12934 added the bug Something isn't working label Aug 20, 2023
@stuebingerb
Copy link
Contributor Author

will probably tweak the coloring a bit :)

Feel free, mine was mostly a proof-of-concept 😉

@stuebingerb stuebingerb deleted the fix-team-name-validation branch October 4, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants