Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style-sheet links to reflect those from jupyter-server #359

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

possiblyMikeB
Copy link
Contributor

@possiblyMikeB possiblyMikeB commented Sep 29, 2024

At some point the jupyter-server project switched from including a combined style-sheet in their page.html template to including three distinct style-sheets.

This pull request changes the head block of the template page.html packaged with nbgitpuller to be consistent with the template of the same name from the jupyter-server package.

This change resolves #358

@agoose77
Copy link

@possiblyMikeB thank you for this PR!

@sgibson91 and I confirmed that this fixes #358.1 Your fix pulls in the dependencies for styling from the upstream jupyter-server. As of the time of writing, Jupyter Server ships these files for all versions of jupyter-server supported by nbgitpuller.

This may change in the future, and we think that another PR down the road should look at bundling bootstrap (or dropping it entirely) into nbgitpuller.

For now, this LGTU (looks good to us!)

Footnotes

  1. https://github.com/2i2c-org/infrastructure/issues/5059

@sgibson91 sgibson91 merged commit f415428 into jupyterhub:main Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status page broken
3 participants