-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: 가이드라인 관련 로직 수정 {프론트 요청) #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오늘 프론트와 협업 작업하시느라 고생하셨습니다 👍
추가하신 더미데이터 엄청 많네요ㄷㄷ
바로 approve 하겠습니다~
Reformat 안된 파일들이 있는 것 같아요!
나중에 각자 맡으신 부분 작업하실 때 Reformat Code 한번씩 부탁드릴게요
넵 알겠습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다! 👏👏👏
public GuardGuidelineService(GuardGuidelineRepository guardGuidelineRepository, SeniorRepository seniorRepository, CallbackRepository callbackRepository, MemberRepository memberRepository) { | ||
this.guardGuidelineRepository = guardGuidelineRepository; | ||
this.seniorRepository = seniorRepository; | ||
this.callbackRepository = callbackRepository; | ||
this.memberRepository = memberRepository; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번 PR에 MemberRepository
가 새로 추가되었는데 사용은 안하시는걸로 확인이 됩니다. 현재 서비스 계층 코드에서 딱히 사용하실 계획이 없으시면 제거해주셔도 좋을거 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 맞아요 감사합니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정하신 부분 확인했습니다! 고생하셧어요~
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close