Refactor: 가이드라인 관련 로직 수정 {프론트 요청) #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
GitJIHO
approved these changes
Oct 22, 2024
zzoe2346
approved these changes
Oct 22, 2024
Comment on lines
32
to
37
| public GuardGuidelineService(GuardGuidelineRepository guardGuidelineRepository, SeniorRepository seniorRepository, CallbackRepository callbackRepository, MemberRepository memberRepository) { | ||
| this.guardGuidelineRepository = guardGuidelineRepository; | ||
| this.seniorRepository = seniorRepository; | ||
| this.callbackRepository = callbackRepository; | ||
| this.memberRepository = memberRepository; | ||
| } |
There was a problem hiding this comment.
이번 PR에 MemberRepository 가 새로 추가되었는데 사용은 안하시는걸로 확인이 됩니다. 현재 서비스 계층 코드에서 딱히 사용하실 계획이 없으시면 제거해주셔도 좋을거 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close