-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: 가이드라인 관련 로직 수정 {프론트 요청) #103
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f23531b
deploy: 가이드라인 더미데이터 추가
eunsoni a0c2b75
feat: 콜백과 가이드라인의 시니어가 같지 않을 때 발생하는 예외 구현
eunsoni 7f2abab
refactor: 타입별 전체 가이드라인 및 특정 가이드라인 조회 시 검증 로직 추가
eunsoni b4f8526
refactor: 가이드라인 조회 api 매개변수 수정
eunsoni 6740854
refactor: Reformat code
eunsoni 6542f4b
refactor: 가이드라인 response dto에 id 추가 및 서비스단 수정
eunsoni b493e3d
refactor: 중복 주석 삭제
eunsoni 0c3bba2
refactor: 서비스단에서 사용하지 않는 레퍼지토리 선언 삭제
eunsoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
130 changes: 130 additions & 0 deletions
130
src/main/java/com/example/sinitto/common/dummy/InitialData.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,5 @@ public record GuardGuidelineRequest( | |
GuardGuideline.Type type, | ||
String title, | ||
String content | ||
) {} | ||
) { | ||
} |
4 changes: 3 additions & 1 deletion
4
...in/java/com/example/sinitto/guardGuideline/exception/GuardGuidelineNotFoundException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
package com.example.sinitto.guardGuideline.exception; | ||
|
||
public class GuardGuidelineNotFoundException extends RuntimeException { | ||
public GuardGuidelineNotFoundException(String message) {super(message);} | ||
public GuardGuidelineNotFoundException(String message) { | ||
super(message); | ||
} | ||
} |
7 changes: 7 additions & 0 deletions
7
...om/example/sinitto/guardGuideline/exception/SeniorAndGuardGuidelineMismatchException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.example.sinitto.guardGuideline.exception; | ||
|
||
public class SeniorAndGuardGuidelineMismatchException extends RuntimeException { | ||
public SeniorAndGuardGuidelineMismatchException(String message) { | ||
super(message); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이번 PR에
MemberRepository
가 새로 추가되었는데 사용은 안하시는걸로 확인이 됩니다. 현재 서비스 계층 코드에서 딱히 사용하실 계획이 없으시면 제거해주셔도 좋을거 같습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 맞아요 감사합니다~!