前後のmessageを更新しようとすると、型チェックで落ちるのを修正 #96
Conversation
WalkthroughThe recent modifications enhance the functionality of user data processing in Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API
participant UserManager
participant MessageManager
Client->>UserManager: getUser(userId)
UserManager->>API: Fetch user detail
API-->>UserManager: Return user detail
UserManager-->>Client: Return User
Client->>MessageManager: channelTimeline(params)
MessageManager->>API: Fetch channel messages
API-->>MessageManager: Return messages
MessageManager-->>Client: Return Message[]
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- denops/traqvim/model.ts (3 hunks)
Additional comments not posted (2)
denops/traqvim/model.ts (2)
142-152: LGTM!The changes improve type safety and clarity by explicitly typing the API response and mapping properties to construct the user object.
Line range hint
185-213:
LGTM!The changes refine the data structures used in the function, improve type definitions, and enhance the control flow regarding how messages are constructed and returned.
However, ensure that all function calls to
channelTimelinematch the new logic.
| @@ -139,7 +139,17 @@ export const homeChannelId = async (): Promise<string> => { | |||
| // userIdからユーザー情報を取得する | |||
| export const getUser = async (userId: string): Promise<traq.User> => { | |||
| const userRes = await api.api.getUser(userId); | |||
| const user = userRes.data; | |||
| const userDetail: traq.UserDetail = userRes.data; | |||
| // TODO: もっと良い変換方法ありそうなんで、見つけたらやっとく | |||
There was a problem hiding this comment.
Reminder: Improve data transformation method.
The TODO comment indicates a potential for finding a better transformation method.
Do you want me to assist in finding and implementing a more efficient data transformation method?
バッファ変数に保存してた情報にvim・denops側で齟齬が生じてたのが原因
denops→vimでundefined→0に解釈されるらしく、
vim→denopsと値が渡されたときにundefinedチェックできない
denops側でundefinedだったら、そもそもvim側に入れないように修正
Summary by CodeRabbit
New Features
Bug Fixes