Removal of secret reader feature

[leandroberetta]

Given that now Kiali will get the certificate information using a configmap, this is not necesary anymore.

[jmazzitelli]

I think you also want to delete the following from the server helm chart:

• file: https://github.com/kiali/helm-charts/blob/v1.89/kiali-server/templates/role-controlplane.yaml
• file: https://github.com/kiali/helm-charts/blob/v1.89/kiali-server/templates/rolebinding-controlplane.yaml
• certificates_information_indicators config section: https://github.com/kiali/helm-charts/blob/v1.89/kiali-server/values.yaml#L106-L110

[leandroberetta]

I think you also want to delete the following from the server helm chart:

• file: https://github.com/kiali/helm-charts/blob/v1.89/kiali-server/templates/role-controlplane.yaml
• file: https://github.com/kiali/helm-charts/blob/v1.89/kiali-server/templates/rolebinding-controlplane.yaml
• certificates_information_indicators config section: https://github.com/kiali/helm-charts/blob/v1.89/kiali-server/values.yaml#L106-L110

Yes, my bad, missing commit.

[jmazzitelli]

looks good.

First, I ran "helm template" on the latest kiali server chart and see the controlplane and certificate stuff:

$ helm template -n istio-system kiali-server kiali/kiali-server | grep -E 'certificate|controlplane'
      certificates_information_indicators:
# Source: kiali-server/templates/role-controlplane.yaml
  name: kiali-controlplane
# Source: kiali-server/templates/rolebinding-controlplane.yaml
  name: kiali-controlplane
  name: kiali-controlplane

Then run the same with the helm charts of this PR built via make build-helm-charts:

$ helm template -n istio-system kiali-server _output/charts/kiali-server-*.tgz | grep -E 'certificate|controlplane'

which returns nothing.

As for the operator, there is now no longer a rule for reading cacert secrets. We see a third rule for secrets in the current release:

$ helm template -n istio-system kiali-operator kiali/kiali-operator | grep '\- secrets'
  - secrets
  - secrets
  - secrets

$ helm template -n istio-system kiali-operator kiali/kiali-operator | grep 'cacerts'
  - cacerts

but those are no longer there in this PR's charts:

$ helm template -n istio-system kiali-operator _output/charts/kiali-operator*.tgz | grep '\- secrets'
  - secrets
  - secrets
$ helm template -n istio-system kiali-operator _output/charts/kiali-operator*.tgz | grep 'cacerts'
(the above command returns empty results)