Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of secret reader feature #285

Merged
merged 2 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions kiali-operator/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,6 @@ rules:
- create
- list
- watch
{{- if gt (len .Values.secretReader) 0 }}
- apiGroups: [""]
resourceNames:
{{- range .Values.secretReader }}
- {{ . }}
{{- end }}
resources:
- secrets
verbs:
- get
{{- end }}
- apiGroups: [""]
resourceNames:
- kiali-signing-key
Expand Down
9 changes: 0 additions & 9 deletions kiali-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,6 @@ watchNamespace: ""
# Note that this will be overriden to "true" if cr.create is true and cr.spec.deployment.cluster_wide_access=true.
clusterRoleCreator: true

# Set to a list of secrets in the cluster that the operator will be allowed to read. This is necessary if you want to
# support Kiali CRs with spec.kiali_feature_flags.certificates_information_indicators.enabled=true.
# The secrets in this list will be the only ones allowed to be specified in any Kiali CR (in the setting
# spec.kiali_feature_flags.certificates_information_indicators.secrets).
# If you set this to an empty list, the operator will not be given permission to read any additional secrets
# found in the cluster, and thus will only support a value of "false" in the Kiali CR setting
# spec.kiali_feature_flags.certificates_information_indicators.enabled.
secretReader: ['cacerts', 'istio-ca-secret']

# Set to true if you want to allow the operator to only be able to install Kiali in view-only-mode.
# The purpose for this setting is to allow you to restrict the permissions given to the operator itself.
onlyViewOnlyMode: false
Expand Down
23 changes: 0 additions & 23 deletions kiali-server/templates/role-controlplane.yaml

This file was deleted.

17 changes: 0 additions & 17 deletions kiali-server/templates/rolebinding-controlplane.yaml

This file was deleted.

5 changes: 0 additions & 5 deletions kiali-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@ identity: {}
#private_key_file:

kiali_feature_flags:
certificates_information_indicators:
enabled: true
secrets:
- cacerts
- istio-ca-secret
disabled_features: []
validations:
ignore: ["KIA1301"]
Expand Down
Loading