Skip to content

Commit

Permalink
ft857: Fix incorrect DTCS handling
Browse files Browse the repository at this point in the history
This driver has been broken forever in how it handles DTCS tone mode.
It was always using the rx_dtcs field, which should only be honored
in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode
always made this clear, as it appeared to be snapping back to 023
always when the user selected a different value.

Note that the test is *also* broken, which I will fix at the end of
this series.

Related to #11506
  • Loading branch information
kk7ds committed Aug 30, 2024
1 parent b9190ce commit 9bedee1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chirp/drivers/ft857.py
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ def _set_tmode(self, mem, _mem):
# this code has already been tested
_mem.dcs = _mem.rxdcs = chirp_common.DTCS_CODES.index(mem.dtcs)
elif mem.tmode == "DTCS":
_mem.dcs = _mem.rxdcs = chirp_common.DTCS_CODES.index(mem.rx_dtcs)
_mem.dcs = _mem.rxdcs = chirp_common.DTCS_CODES.index(mem.dtcs)
elif mem.tmode == "Cross":
_mem.tone = chirp_common.TONES.index(mem.rtone)
_mem.rxtone = chirp_common.TONES.index(mem.ctone)
Expand Down

0 comments on commit 9bedee1

Please sign in to comment.