Change NEEDS_COMPAT_SERIAL default #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Jun 16, 2024
kk7ds
commented
- Change "compat serial" flag to default off
- Remove compat serial override from maintained drivers
This is long overdue, but we can flip the NEEDS_COMPAT_SERIAL flag to off now, since almost everything is migrated and then new drivers won't have to add it. The fact that there are no changes to the test matrix shows that this doesn't change the status of any drivers. All the ones that were inheriting the old default have been explicitly opted into compat behavior.
Almost all the drivers in the tree now opt out of the byte-compat behavior. The default has been flipped, so we can remove that from all those drivers and remove it from the PR template so people don't have to think about it anymore.
Fixes: #11383
This will upload the config file, debug log, and image file to an issue if the user provides credentials.
This should fix situations where the default encoding (i.e. on windows) is not sufficient for writing certain characters. That could be paths (in the recent list) or anything else we store there that expects full unicode. Fixes #11385
A number of things weren't right with this, likely for a while, since we had no tests or examples in the tree. This adds three user-supplied sample files and a test to hopefully keep it working. Fixes: - Ignore blank entries - Tolerate a missing "Channel Number" column - Support the "Scan" (meaning not skip) column type - Fix detection by being looser about what we look for Fixes #11389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.