Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NEEDS_COMPAT_SERIAL default #1066

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Change NEEDS_COMPAT_SERIAL default #1066

merged 6 commits into from
Jun 18, 2024

Commits on Jun 17, 2024

  1. Change "compat serial" flag to default off 

    This is long overdue, but we can flip the NEEDS_COMPAT_SERIAL flag
to off now, since almost everything is migrated and then new drivers
won't have to add it.

The fact that there are no changes to the test matrix shows that this
doesn't change the status of any drivers. All the ones that were
inheriting the old default have been explicitly opted into compat
behavior.
    @kk7ds
    kk7ds committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    aedb03b View commit details
    Browse the repository at this point in the history

  2. Remove compat serial override from maintained drivers 

    Almost all the drivers in the tree now opt out of the byte-compat
behavior. The default has been flipped, so we can remove that from
all those drivers and remove it from the PR template so people don't
have to think about it anymore.
    @kk7ds
    kk7ds committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6341511 View commit details
    Browse the repository at this point in the history

  3. Add Baofeng BF-18H and BF-18L to alias map 

    Fixes: #11383
    @kk7ds
    kk7ds committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a2a7d74 View commit details
    Browse the repository at this point in the history

  4. Add "Help->Send details for a bug" tool 

    This will upload the config file, debug log, and image file to an
issue if the user provides credentials.
    @kk7ds
    kk7ds committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ce22b01 View commit details
    Browse the repository at this point in the history

  5. Always read/write config in UTF-8 

    This should fix situations where the default encoding (i.e. on windows)
is not sufficient for writing certain characters. That could be paths
(in the recent list) or anything else we store there that expects
full unicode.

Fixes #11385
    @kk7ds
    kk7ds committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    26f7c11 View commit details
    Browse the repository at this point in the history

  6. Fix reading RTSystems CSV files 

    A number of things weren't right with this, likely for a while, since
we had no tests or examples in the tree. This adds three user-supplied
sample files and a test to hopefully keep it working. Fixes:

- Ignore blank entries
- Tolerate a missing "Channel Number" column
- Support the "Scan" (meaning not skip) column type
- Fix detection by being looser about what we look for

Fixes #11389
    @kk7ds
    kk7ds committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    329ecd5 View commit details
    Browse the repository at this point in the history