Fix DTCS test and three drivers #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Aug 30, 2024
kk7ds
commented
- anytone778uv: Fix incorrect DTCS handling
- ft4: Fix incorrect DTCS handling
- ft857: Fix incorrect DTCS handling
- Fix test_dtcs and test_cross skipping
This driver has been broken forever in how it handles DTCS tone mode. It was always using the rx_dtcs field, which should only be honored in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode always made this clear, as it appeared to be snapping back to 023 always when the user selected a different value. Note that the test is *also* broken, which I will fix at the end of this series. Fixes: #11506
This driver has been broken forever in how it handles DTCS tone mode. It was always using the rx_dtcs field, which should only be honored in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode always made this clear, as it appeared to be snapping back to 023 always when the user selected a different value. Note that the test is *also* broken, which I will fix at the end of this series. Related to #11506
This driver has been broken forever in how it handles DTCS tone mode. It was always using the rx_dtcs field, which should only be honored in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode always made this clear, as it appeared to be snapping back to 023 always when the user selected a different value. Note that the test is *also* broken, which I will fix at the end of this series. Related to #11506
This test has been wrong for a long time, basically never properly asserting DTCS values for drivers. The three drivers fixed immediately before this commit should have been caught by this test, but were not because it was always skipping the dtcs field. Related to #11506
Fixes #11508
This should make it more obvious for people looking for model variantions (like RT95 VOX). Related to #11509
kk7ds
force-pushed
the
bug/11506/rt95dtcs
branch
from
c0f21ea
to
f4a337c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.