Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DTCS test and three drivers #1100

Merged
merged 6 commits into from
Aug 31, 2024
Merged

Fix DTCS test and three drivers #1100

merged 6 commits into from
Aug 31, 2024

Commits on Aug 31, 2024

  1. anytone778uv: Fix incorrect DTCS handling 

    This driver has been broken forever in how it handles DTCS tone mode.
It was always using the rx_dtcs field, which should only be honored
in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode
always made this clear, as it appeared to be snapping back to 023
always when the user selected a different value.

Note that the test is *also* broken, which I will fix at the end of
this series.

Fixes: #11506
    @kk7ds
    kk7ds committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    4a36fc6 View commit details
    Browse the repository at this point in the history

  2. ft4: Fix incorrect DTCS handling 

    This driver has been broken forever in how it handles DTCS tone mode.
It was always using the rx_dtcs field, which should only be honored
in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode
always made this clear, as it appeared to be snapping back to 023
always when the user selected a different value.

Note that the test is *also* broken, which I will fix at the end of
this series.

Related to #11506
    @kk7ds
    kk7ds committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    cb39845 View commit details
    Browse the repository at this point in the history

  3. ft857: Fix incorrect DTCS handling 

    This driver has been broken forever in how it handles DTCS tone mode.
It was always using the rx_dtcs field, which should only be honored
in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode
always made this clear, as it appeared to be snapping back to 023
always when the user selected a different value.

Note that the test is *also* broken, which I will fix at the end of
this series.

Related to #11506
    @kk7ds
    kk7ds committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    e5a18ea View commit details
    Browse the repository at this point in the history

  4. Fix test_dtcs and test_cross skipping 

    This test has been wrong for a long time, basically never properly
asserting DTCS values for drivers. The three drivers fixed immediately
before this commit should have been caught by this test, but were not
because it was always skipping the dtcs field.

Related to #11506
    @kk7ds
    kk7ds committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    14c33f1 View commit details
    Browse the repository at this point in the history

  5. ga510: Fix ANI group code out of range 

    Fixes #11508
    @kk7ds
    kk7ds committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    f2a8faa View commit details
    Browse the repository at this point in the history

  6. Expose detected model variants in clone box 

    This should make it more obvious for people looking for model
variantions (like RT95 VOX).

Related to #11509
    @kk7ds
    kk7ds committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    f4a337c View commit details
    Browse the repository at this point in the history