Bulk settings index conversions #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Sep 9, 2024
kk7ds
commented
- rt490: Hand-fix a complex settings list index
- First pass at mass settings index fixes
- Mass convert self.LIST settings indexes
- Hand-fix some settings list indexes with variables
- Add Baofeng AR-5RM to model alias map
- Limit bugreport subject field
This is the first pass at converting all drivers to use current_index instead of current (value) when defining RadioSettingValueList items. These are just the easy/straightforward cases where we have a list and and index into that list. Other instances with more complex invocations will be handled separately. The files that ended up with long lines as a result of this were autopep8'd with just long-line fixes applied.
Fixes #11525
A user might think this is their only opportunity to put in details and stuff a tome into this field.
kk7ds
force-pushed
the
bulk-settings-indexes
branch
from
7bed337
to
33d0076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.