Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the kmeshctl documentation according to make gen #1241

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

LiZhenCheng9527
Copy link
Collaborator

@LiZhenCheng9527 LiZhenCheng9527 commented Feb 14, 2025

What type of PR is this?

What this PR does / why we need it:
Modify the kmeshctl documentation according to make gen
Which issue(s) this PR fixes:
#1239 is blocked by this problem

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@LiZhenCheng9527
Copy link
Collaborator Author

/cc @hzxuzhonghu

@YaoZengzeng
Copy link
Member

/lgtm we should merge this ASAP.

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 724789d into kmesh-net:main Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants