[Add Feat] Implemented Multi Sinks Venting Simulation#13
Open
anshRastogi02 wants to merge 2 commits intoknative-extensions:mainfrom
Open
[Add Feat] Implemented Multi Sinks Venting Simulation#13anshRastogi02 wants to merge 2 commits intoknative-extensions:mainfrom
anshRastogi02 wants to merge 2 commits intoknative-extensions:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anshRastogi02 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @anshRastogi02! It looks like this is your first PR to knative-extensions/educational-game 🎉 |
3 tasks
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current game features one sink and a two-event venting simulation. In this update, I have expanded it to include three sinks, three events, and three filters, allowing for a more effective simulation of event allocation to the respective sinks using the appropriate filters
Changes
Fixes #12
Reference
https://github.com/anshRastogi02/educational-game
I kindly request @Cali0707 and @zainabhusain227 to review this pull request. Please let me know if any changes are needed. I welcome any feedback or suggestions for further improvements!