Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nanoflann #42

Merged
merged 13 commits into from
May 2, 2024
Merged

Replace nanoflann #42

merged 13 commits into from
May 2, 2024

Conversation

koide3
Copy link
Owner

@koide3 koide3 commented May 1, 2024

Replace nanoflann with new KdTree implementation for the following reasons:

  • To resolve the conflict of nanoflann namespace with ones in other packages.
  • To simplify the KdTree usage. OMP and TBB-based tree construction routines now return the same KdTree class.
  • To improve the KdTree query speed. Note that it's not a major improvement. Only a few percent speed up comes at the cost of flexibility limitation (The new KdTree can only process 3D points).

EDIT: Task-based OpenMP parallelism causes memory issues with Eigen matrices on MSVC. To avoid it, disable parallel kdtree construction on MSVC.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 97.38562% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.50%. Comparing base (86c2e40) to head (fd418bb).
Report is 2 commits behind head on master.

Files Patch % Lines
include/small_gicp/ann/knn_result.hpp 83.33% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   91.77%   88.50%   -3.28%     
==========================================
  Files          35       36       +1     
  Lines        1179      774     -405     
  Branches      182       70     -112     
==========================================
- Hits         1082      685     -397     
+ Misses         97       89       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koide3 koide3 merged commit 0d31eda into master May 2, 2024
9 checks passed
@koide3 koide3 deleted the noflann branch May 2, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants