treat warnings as errors in mdspan tests#328
Conversation
When compiling mdspan tests, treat compiler warnings as error. This option is *not* propagated to consumers of mdspan.
| add_executable(${name} ${name}.cpp) | ||
| target_link_libraries(${name} mdspan gtest_main) | ||
| add_test(${name} ${name}) | ||
| set_property(TARGET ${name} PROPERTY COMPILE_WARNING_AS_ERROR ON) |
There was a problem hiding this comment.
This isn't supported by the (admittedly quite old) minimum CMake version we require. I'd suggest an option (i.e. MDSPAN_WARNINGS_AS_ERRORS) that defaults to ON and then we use custom cmake logic to set the associated flags. Alternatively, I'd support bumping our minimum cmake version to 3.24 but not sure how others feel about that :P
There was a problem hiding this comment.
People may want the option to turn off warnings-as-errors for tests, especially since different compilers emit different warnings (some of which are spurious). A CMake option sounds like something we would want anyway.
There was a problem hiding this comment.
agreed -- though I just found out with COMPILE_WARNING_AS_ERROR you can pass --compile-no-warning-as-error to cmake to suppress it. But that's only with cmake 3.24
There was a problem hiding this comment.
Neat! That sounds particularly useful, esp. for people who have to configure for MSVC but don't know what flag to use.
|
Looks like we already merged this in #314 So I'm closing this |
3 participants
When compiling mdspan tests, treat compiler warnings as error. This option is not propagated to consumers of mdspan.