Skip to content

treat warnings as errors in mdspan tests #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliverlee wants to merge 1 commit into from
Closed

treat warnings as errors in mdspan tests #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ macro(mdspan_add_test name)
add_executable(${name} ${name}.cpp)
target_link_libraries(${name} mdspan gtest_main)
add_test(${name} ${name})
set_property(TARGET ${name} PROPERTY COMPILE_WARNING_AS_ERROR ON)
Copy link
Contributor

@nmm0 nmm0 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't supported by the (admittedly quite old) minimum CMake version we require. I'd suggest an option (i.e. MDSPAN_WARNINGS_AS_ERRORS) that defaults to ON and then we use custom cmake logic to set the associated flags. Alternatively, I'd support bumping our minimum cmake version to 3.24 but not sure how others feel about that :P

Copy link
Contributor

@mhoemmen mhoemmen May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People may want the option to turn off warnings-as-errors for tests, especially since different compilers emit different warnings (some of which are spurious). A CMake option sounds like something we would want anyway.

Copy link
Contributor

@nmm0 nmm0 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed -- though I just found out with COMPILE_WARNING_AS_ERROR you can pass --compile-no-warning-as-error to cmake to suppress it. But that's only with cmake 3.24

Copy link
Contributor

@mhoemmen mhoemmen May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! That sounds particularly useful, esp. for people who have to configure for MSVC but don't know what flag to use.

endmacro()

if(MDSPAN_USE_SYSTEM_GTEST)
Expand Down